Skip to content

feat: prefix env variables with ENVBUILDER #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 13, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Contributor

Closes #166

@BrunoQuaresma BrunoQuaresma requested review from johnstcn and mtojek May 10, 2024 13:20
@BrunoQuaresma BrunoQuaresma self-assigned this May 10, 2024
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need any unit tests here?

@BrunoQuaresma BrunoQuaresma requested a review from mtojek May 10, 2024 14:01
@BrunoQuaresma
Copy link
Contributor Author

Do you think we need any unit tests here?

Yes, I was waiting for some review to see if I was in the right direction. 👍

@mtojek
Copy link
Member

mtojek commented May 10, 2024

Awesome! Looking forward to see some tests 👍

@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review May 10, 2024 16:30
@BrunoQuaresma BrunoQuaresma requested a review from johnstcn May 10, 2024 18:20
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thorough tests 👍

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mtojek
Copy link
Member

mtojek commented May 13, 2024

just make sure that CI is happy

@BrunoQuaresma BrunoQuaresma merged commit c196133 into main May 13, 2024
3 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/add-env-prefix branch May 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(breaking) Prefix all envbuilder environment variables with ENVBUILDER_
3 participants