Skip to content

chore: format go code using gofumpt #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 3, 2024
Merged

chore: format go code using gofumpt #172

merged 11 commits into from
May 3, 2024

Conversation

BrunoQuaresma
Copy link
Contributor

No description provided.

@BrunoQuaresma BrunoQuaresma requested a review from johnstcn May 3, 2024 14:01
@BrunoQuaresma BrunoQuaresma self-assigned this May 3, 2024
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review May 3, 2024 14:29
@johnstcn johnstcn requested review from mafredri and dannykopping May 3, 2024 14:34
johnstcn
johnstcn approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit about the github runner conditionals for windows

dannykopping
dannykopping approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mafredri
mafredri reviewed May 3, 2024
View reviewed changes
matifali
matifali reviewed May 3, 2024
View reviewed changes
matifali
matifali reviewed May 3, 2024
View reviewed changes
matifali
matifali previously requested changes May 3, 2024
View reviewed changes
@matifali matifali dismissed their stale review May 3, 2024 18:18

not blocking you after you make changes.

@BrunoQuaresma
Copy link
Contributor Author

@matifali should we make test, docs, and fmt required?

@BrunoQuaresma BrunoQuaresma requested a review from mafredri May 3, 2024 18:26
@matifali
Copy link
Member

matifali commented May 3, 2024

@BrunoQuaresma Yes I think. Someone with admin rights to the repo can mark jobs as required.

@BrunoQuaresma BrunoQuaresma merged commit 5d0a0f3 into main May 3, 2024
3 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/use-gofumt-to-format-code branch May 3, 2024 18:30
mafredri
mafredri reviewed May 3, 2024
View reviewed changes
@BrunoQuaresma
Copy link
Contributor Author

@mafredri follow-ups here #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri left review comments

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

@matifali matifali matifali left review comments

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrunoQuaresma @matifali @mafredri @dannykopping @johnstcn