Skip to content

test: add test for options env #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2024
Merged

test: add test for options env #161

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73696ae
test: add test for options env
BrunoQuaresma Apr 29, 2024
deab071
Apply suggestions from Danny's code review
BrunoQuaresma Apr 29, 2024
b091ca7
Remove unecessary type
BrunoQuaresma Apr 29, 2024
b76a4c0
Split tests by type and improve boolean tests
BrunoQuaresma Apr 29, 2024
5d2dd65
Fix tests and group them
BrunoQuaresma Apr 29, 2024
ffe9331
Expresse the test intent more concisely
BrunoQuaresma Apr 30, 2024
3a7e2e5
Improve readability
BrunoQuaresma Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package envbuilder_test

import (
"testing"

"github.com/coder/envbuilder"
"github.com/coder/serpent"
"github.com/stretchr/testify/require"
)

type testEnvCase struct {
Env string
EnvValue string
Expected interface{}
Actual func() interface{}
}

func TestEnvOptions(t *testing.T) {
t.Setenv("SETUP_SCRIPT", "setup.sh")
t.Setenv("CACHE_TTL_DAYS", "7")
t.Setenv("IGNORE_PATHS", "/var,/tmp")
t.Setenv("SKIP_REBUILD", "true")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code was using https://pkg.go.dev/strconv#ParseBool, but I'm not sure what the new code is using so we might need to test 1/0/true/false (and the latter two's capitalised equivalents).

t.Setenv("GIT_CLONE_SINGLE_BRANCH", "")

var o = envbuilder.Options{}
cmd := serpent.Command{
Options: o.CLI(),
Handler: func(inv *serpent.Invocation) error {
return nil
},
}
err := cmd.Invoke().WithOS().Run()
require.NoError(t, err)

require.Equal(t, o.SetupScript, "setup.sh")
require.Equal(t, o.CacheTTLDays, int64(7))
require.Equal(t, o.IgnorePaths, []string{"/var", "/tmp"})
require.True(t, o.SkipRebuild)
require.False(t, o.GitCloneSingleBranch)
}
Loading