feat: allow custom build context to be configured when using DOCKERFILE_PATH
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e base workspace dir Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
commented
Apr 24, 2024
| }, | ||
| { | ||
| // Dockerfile & build context are not in the same dir, but inclFile is in the default build context dir; | ||
| // this should allow inclFile to be copied. This is probably not desirable though? |
There was a problem hiding this comment.
Reviewer: should we warn when a Dockerfile is used outside the WorkspaceFolder, because the build context will likely be wrong?
There was a problem hiding this comment.
You could also make an argument for failing the build entirely; but I think warning is fine here.
johnstcn
approved these changes
Apr 24, 2024
mafredri
approved these changes
Apr 24, 2024
| @@ -476,7 +480,7 @@ func Run(ctx context.Context, options Options) error { | |||
| buildParams = &devcontainer.Compiled{ | |||
| DockerfilePath: dockerfilePath, | |||
| DockerfileContent: string(content), | |||
| BuildContext: options.WorkspaceFolder, | |||
| BuildContext: filepath.Join(options.WorkspaceFolder, options.BuildContextPath), | |||
There was a problem hiding this comment.
Since WorkspaceFolder is optional, what's the end-result if it's not provided, will this be correct?
There was a problem hiding this comment.
WorkspaceFolder will be given a default value if none is provided:
Lines 270 to 276 in 0643d17
dannykopping
force-pushed
the
dk/dockerfile-path
branch
from
4bb1307 to
4dbe75b
Compare
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
force-pushed
the
dk/dockerfile-path
branch
from
4dbe75b to
73e8800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129