Keep readonly-volume-mounted config.json #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104.
Bug description
The config.json deletion code
envbuilder/envbuilder.go
Line 775 in 8962d96
seems intended to delete previously generated temporary one.
envbuilder/envbuilder.go
Line 314 in 8962d96
But in case config.json file is volume mounted with read-only mode on Docker or Kubernetes, the deletion fails with
error: remove docker config: remove /.envbuilder/config.json: device or resource busy
.Bug fix
Delete config.json only if it is generated from
DOCKER_CONFIG_BASE64
environment variable.Validation
Execute the following commands, and a deno devcontainer will run without errors.