chore: embed Info.plist
in dylib
#15907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to coder/coder-desktop-macos#2
This embeds:
CFBundleName
2.18.1-devel+1317c3043
asCFBundleVersion
2.18.1
asCFBundleShortVersionString
com.coder.Coder-Desktop.VPN.dylib
asCFBundleIdentifier
.into the
__TEXT __info_plist
section of the Coder VPN.dylib
. This allows the Desktop app to read the version of the dylib after it's been downloaded.There exists a Swift API for reading this section: https://developer.apple.com/documentation/corefoundation/1537134-cfbundlecopyinfodictionaryforurl
Note:
I initially tried to see if
Info.plist
could be embedded within the signature usingrcodesign
. It lets you supply anInfo.plist
but it would appear to only add the hash of the file to the signature, see example.Inspecting the signature with
codesign
would returnInfo.plist=not bound
.