Open a new window with Open VS Code Desktop

[sharkymark]

The awesome new feature, Open VS Code Desktop, opens the existing local VS Code window so when I close it, I have to re-open my local 'workspace' again.

I suggest the default behavior be to open a new VS Code window locally.

[jsjoeio]

I believe the URI that handles the opening in VS Code is here:

coder/site/src/components/VSCodeDesktopButton/VSCodeDesktopButton.tsx

Lines 26 to 36 in bbb208e

	const query = new URLSearchParams({
	owner: userName,
	workspace: workspaceName,
	url: location.origin,
	token: key,
	})
	if (agentName) {
	query.set("agent", agentName)
	}
	location.href = `vscode://coder.coder-remote/open?${query.toString()}`

So we'd have to see what params vscode:// and hope that it supports something like newWindow=true or something.

Looks like these are our query params so we could support it on this side. Curious though if we can support it from the vscode-coder extension side.

[jsjoeio]

So our custom URI handler is here:

https://github.com/coder/vscode-coder/blob/ec4aa92aa7717740a5a1a66d4350236c9bcf913e/src/extension.ts#L27-L51

[jsjoeio]

I believe actual code to open VS Code window would be here: https://github.com/coder/vscode-coder/blob/ec4aa92aa7717740a5a1a66d4350236c9bcf913e/src/commands.ts#L188-L194

[jsjoeio]

Ah maybe this is it? https://github.com/coder/vscode-coder/blob/ec4aa92aa7717740a5a1a66d4350236c9bcf913e/src/commands.ts#L200

see reuseWindow: true. We'd want to set that to false.

So seems like it's possible if I'm following the logic correctly.