Skip to content

fix: simplify and improve error handling during workspace polling #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Apr 14, 2025

  • detect if there is an os wake-up for all types of errors
  • if there is an os wake-up we try to re-init the http client.
  • if that doesn't work out, the polling stops and redirects to the autologin screen.
  • the autologin screen will display an error and stop the authentication if errors are encountered.

- detect if there is os wake-up for all types of errors
- if there is an os wake-up we try to re-init the http client
- if that doesn't work out, the polling stops and redirects to the autologin screen.
- the autologin screen will display an error and stop the authentication if errors are encountered
@fioan89 fioan89 requested review from matifali and f0ssel April 14, 2025 14:15
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fioan89 fioan89 merged commit fc24b7d into main Apr 14, 2025
5 checks passed
@fioan89 fioan89 deleted the improved-polling-error-handling branch April 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants