chore: add Vpn.Service app for Manager #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements a basic .NET hosted service manager architecture with Microsoft.Extensions - Adds a Manager and ManagerService for handling Manager lifecycle - Adds a ManagerRpcService for managing the RPC server and passing requests to the Manager singleton - Adds a Downloader for handling singleflight for downloading files - Implements downloading with progress reporting, ETag validation, and Authenticode validation
|
This PR is getting huge so I'm going to get this merged so I can request reviews in smaller chunks going forward. Most of this is the boilerplate which enables writing the actual application code (although I probably could've done the Downloader in another PR at the very least :/) |
ethanndickson
approved these changes
Dec 13, 2024
| _handler = handler; | ||
|
|
||
| // Yes, this is the best way to get an unused port using HttpListener. | ||
| // It sucks. |
| [RegularExpression(@"^([a-zA-Z0-9_-]+\.)*[a-zA-Z0-9_-]+$")] | ||
| public string ServiceRpcPipeName { get; set; } = "Coder.Desktop.Vpn"; | ||
|
|
||
| // TODO: pick a better default path |
There was a problem hiding this comment.
Can't be writable by users so it will definitely be in ProgramData or Program Files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
TODO:
AuthenticodeDownloadValidatortests with binaries (I guess download them from somewhere and cache them during the test?)ClientMessageand merge upstream, updatevpn.protoClientMessagerequests/responsesRelates to #2