Skip to content

chore: add SizedFrame for window sizing #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Mar 11, 2025

First part of sign-in revamp.

Adds a SizedFrame to unify some of the quirky window sizing code, as it's now used in SignInWindow as well as TrayWindow.

It'll also be used in FileSyncListWindow

@deansheather deansheather changed the title feat: revamp sign-in screen chore: add SizedFrame for window sizing Mar 12, 2025
@deansheather deansheather marked this pull request as ready for review March 12, 2025 00:05
Copy link
Collaborator

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to fix Width vs Height (comment inline). I don't need to review again.

{
ResizeWindow();
ResizeWindow(e.NewSize.Width);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ResizeWindow(e.NewSize.Width);
ResizeWindow(e.NewSize.Height);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@deansheather deansheather enabled auto-merge (squash) March 14, 2025 07:25
@deansheather deansheather merged commit 24853b0 into main Mar 14, 2025
3 checks passed
@deansheather deansheather deleted the dean/sign-in-revamp branch March 14, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants