chore: enforce minimum coder server version of v2.20.0 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/require-coder-v2.20
branch
from
6bb49a5 to
33ff2f5
Compare
ethanndickson
commented
Mar 4, 2025
|
I've already tested it a bunch manually, but I wanna sanity check this works after the Coder release is made, so DNM for now. |
ethanndickson
force-pushed
the
ethan/require-coder-v2.20
branch
from
33ff2f5 to
0653766
Compare
|
Works against dev.coder, last PR to get in before new release |
ThomasK33
reviewed
Mar 6, 2025
ethanndickson
force-pushed
the
ethan/require-coder-v2.20
branch
from
0653766 to
27a805a
Compare
ethanndickson
force-pushed
the
ethan/require-coder-v2.20
branch
from
73b126d to
d23b1a2
Compare
ThomasK33
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause Coder Desktop networking to fail to start unless the validated dylib is version
v2.20.0or later. Obviously, using this build early would mean Coder Desktop would not work against our dogfood deployment.