Skip to content

chore: improve text contrast on light mode #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Feb 26, 2025

I discovered you pretty much never want to use gray as a text colour. secondary is only gray where appropriate.
The menu bar tray is slightly transparent, and .secondary and .primary text colours account for that.
As seen below, dark mode is almost unchanged.

Light Mode

Before (on a dark background)

image image

After (on a dark background)

image image

Note: Apple's decided to make secondary darker than primary in this case.

After (on a light background)

image image

Dark Mode

Before

image image

After

image image

Copy link
Member Author

ethanndickson commented Feb 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review February 26, 2025 08:18
@ethanndickson ethanndickson self-assigned this Feb 26, 2025
Copy link
Member Author

ethanndickson commented Feb 27, 2025

Merge activity

  • Feb 26, 10:22 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 10:25 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 26, 10:27 PM EST: A user merged this pull request with Graphite.

@ethanndickson ethanndickson changed the base branch from ethan/reduce-err-verbosity to graphite-base/80 February 27, 2025 03:22
@ethanndickson ethanndickson changed the base branch from graphite-base/80 to main February 27, 2025 03:24
@ethanndickson ethanndickson merged commit 5b4b174 into main Feb 27, 2025
4 checks passed
@deansheather deansheather deleted the ethan/text-contrast branch March 7, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants