chore: improve text contrast on light mode #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered you pretty much never want to use
gray
as a text colour.secondary
is only gray where appropriate.The menu bar tray is slightly transparent, and
.secondary
and.primary
text colours account for that.As seen below, dark mode is almost unchanged.
Light Mode
Before (on a dark background)
After (on a dark background)
Note: Apple's decided to make
secondary
darker thanprimary
in this case.After (on a light background)
Dark Mode
Before
After