fix: improve wake & sleep handling #74
Conversation
| @@ -142,6 +142,11 @@ class PacketTunnelProvider: NEPacketTunnelProvider, @unchecked Sendable { | |||
| } | |||
|
|
|||
| override func wake() { | |||
| guard !reasserting else { return } | |||
There was a problem hiding this comment.
macOS does indeed wake a bunch during sleep to check the network. For us dogfooding, this means it might attempt to download a new dylib while the device sleeps, which the user won't be able to approve. In that case it'll get stuck in reasserting, in this case (and in any case, really) we don't want to try and start it up a second time.
There was a problem hiding this comment.
Got it. Would you also mind adding that as a code comment?
| globalXPCListenerDelegate.vpnXPCInterface.manager = nil | ||
| self.manager = nil | ||
| completionHandler() | ||
| } | ||
| self.manager = nil | ||
| } |
There was a problem hiding this comment.
We want self.manager being nil to be our code's perspective as to whether a stop operation has actually finished. Before, it was nil a little too early, though I don't think it was causing any issues.
There was a problem hiding this comment.
Would you mind adding that as a code comment?
| guard manager == nil else { | ||
| logger.error("wake called with non-nil Manager") | ||
| return | ||
| } |
There was a problem hiding this comment.
This was previously in the start function called right after, but we should avoid resetting the network settings needlessly if we can.
No description provided.