fix: pass configured http headers to network extension #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
force-pushed
the
ethan/state-merge
branch
from
81bc396 to
de12d33
Compare
ethanndickson
force-pushed
the
ethan/headers-to-ne
branch
from
c53ab62 to
fcab6a6
Compare
ThomasK33
reviewed
Feb 18, 2025
ThomasK33
reviewed
Feb 18, 2025
ethanndickson
force-pushed
the
ethan/headers-to-ne
branch
from
fcab6a6 to
67ea616
Compare
ThomasK33
approved these changes
Feb 18, 2025
ethanndickson
changed the base branch from
ethan/state-merge
to
graphite-base/52
ethanndickson
added a commit
that referenced
this pull request
Feb 19, 2025
Unfortunately necessary for #52, as we need the HTTP headers from settings when creating the protocol configuration (which is derived from the session). The class retains all the same invariants as before.
ethanndickson
force-pushed
the
ethan/headers-to-ne
branch
from
67ea616 to
6c7ae7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to do this..