Skip to content

chore: improve login form styling #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jan 15, 2025

Definitely not a super crucial change, but this brings the login form styling in-line with the settings menu that I'm currently working on (for literal HTTP headers).

newloginflow.mov

Also binds esc via .cancelAction to both the Cancel and Back buttons.

Copy link
Member Author

ethanndickson commented Jan 15, 2025

@ethanndickson ethanndickson marked this pull request as ready for review January 15, 2025 07:06
@ethanndickson ethanndickson self-assigned this Jan 15, 2025
@ethanndickson ethanndickson force-pushed the ethan/nicer-login-form branch from 4d2e62f to 7173c04 Compare January 16, 2025 07:34
@ethanndickson ethanndickson force-pushed the ethan/nicer-login-form branch 2 times, most recently from f0465a3 to 5d97953 Compare January 17, 2025 09:18
@ethanndickson ethanndickson force-pushed the ethan/nicer-login-form branch from 5d97953 to c3ea373 Compare January 22, 2025 05:24
@ethanndickson ethanndickson changed the base branch from ethan/codersdk-refactor to main January 22, 2025 05:25
@ethanndickson ethanndickson requested a review from coadler January 22, 2025 10:56
Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better!

@ethanndickson ethanndickson merged commit 63f29ef into main Jan 23, 2025
1 check passed
@ethanndickson ethanndickson deleted the ethan/nicer-login-form branch January 23, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants