Skip to content

feat: add coder connect startup progress indicator #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 22, 2025
Merged

feat: add coder connect startup progress indicator #161

merged 12 commits into from
May 22, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 15, 2025 •
edited
Loading

Closes #159.

loadingdemo.mov

@ethanndickson ethanndickson mentioned this pull request May 15, 2025
Merged
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented May 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson linked an issue May 15, 2025 that may be closed by this pull request
Show progress when connecting to VPN #159
Closed
@ethanndickson ethanndickson mentioned this pull request May 16, 2025
Merged
ethanndickson added a commit that referenced this pull request May 16, 2025
@ethanndickson
fix: set network extension as unconfigured when system extension is d…
9f356e5 
…eleted (#162)

This fixes a bug when `Launch Coder Connect at startup` is enabled when updating the app with #161, where the app attempts to start too early, as it thinks the VPN is configured, but it was unconfigured with the deletion of the system extension.
@ethanndickson ethanndickson force-pushed the ethan/add-privileged-helper branch from 5569302 to 6014bef Compare May 16, 2025 05:41
@ethanndickson ethanndickson changed the title feat: add coder connect startup progress messages feat: add coder connect startup progress indicator May 16, 2025
@ethanndickson ethanndickson marked this pull request as ready for review May 19, 2025 06:07
@ethanndickson ethanndickson changed the base branch from ethan/add-privileged-helper to graphite-base/161 May 19, 2025 09:29
@graphite-app graphite-app bot changed the base branch from graphite-base/161 to main May 19, 2025 09:30
deansheather
deansheather reviewed May 19, 2025
View reviewed changes
@ethanndickson ethanndickson mentioned this pull request May 20, 2025
Merged
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented May 22, 2025 •
edited
Loading

Merge activity

  • May 22, 3:59 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 22, 4:00 AM UTC: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 2adace3 into main May 22, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/xpc-progress branch May 22, 2025 04:00
@ethanndickson ethanndickson self-assigned this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali left review comments

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show progress when connecting to VPN
3 participants
@ethanndickson @matifali @deansheather