feat: add progress messages when creating sync sessions #139
+73
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
commented
Apr 23, 2025
| @@ -69,6 +68,9 @@ struct VPNMenuState { | |||
| invalidAgents.append(agent) | |||
| return | |||
| } | |||
| // Remove trailing dot if present | |||
| let nonEmptyHosts = agent.fqdn.map { $0.hasSuffix(".") ? String($0.dropLast()) : $0 } | |||
There was a problem hiding this comment.
The array being non-empty is checked above.
deansheather
approved these changes
Apr 23, 2025
ethanndickson
force-pushed
the
ethan/sync-progress
branch
from
bd5638d to
1063155
Compare
|
I redid it using a callback instead of some global state, and added a progressview: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loading might take a minute on a poor connection, and there's currently no feedback indicating what's going on, so we can display the prompt messages in the meantime.
i.e. setting up a workspace with a fair bit of latency:
createsyncprogress.mov
This PR also contains a small refactor for the
AgentprimaryHost, removing all the subsequent nil checks as we know it exists on creation.