-
Notifications
You must be signed in to change notification settings - Fork 2
feat: use the deployment's hostname suffix in the UI #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+105
−8
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6462177
feat: use the deployment's hostname suffix in the UI
ethanndickson f141a74
fixup
ethanndickson 5dea75f
fixup
ethanndickson e04f61a
thinking
ethanndickson cbd8ce4
move on start
ethanndickson a354ebe
review
ethanndickson 75f17ca
fmt
ethanndickson ba2d732
fixup
ethanndickson 26d2eb8
single cancelable refresh task
ethanndickson b6218fc
logs
ethanndickson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import Foundation | ||
|
||
public func retry<T>( | ||
floor: Duration, | ||
ceil: Duration, | ||
rate: Double = 1.618, | ||
operation: @Sendable () async throws -> T | ||
) async throws -> T { | ||
var delay = floor | ||
|
||
while !Task.isCancelled { | ||
do { | ||
return try await operation() | ||
} catch let error as CancellationError { | ||
throw error | ||
} catch { | ||
try Task.checkCancellation() | ||
|
||
delay = min(ceil, delay * rate) | ||
try await Task.sleep(for: delay) | ||
} | ||
} | ||
|
||
throw CancellationError() | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import Foundation | ||
|
||
public extension Client { | ||
func agentConnectionInfoGeneric() async throws(SDKError) -> AgentConnectionInfo { | ||
let res = try await request("/api/v2/workspaceagents/connection", method: .get) | ||
guard res.resp.statusCode == 200 else { | ||
throw responseAsError(res) | ||
} | ||
return try decode(AgentConnectionInfo.self, from: res.data) | ||
} | ||
} | ||
|
||
public struct AgentConnectionInfo: Codable, Sendable { | ||
public let hostname_suffix: String? | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by fix: we need to check for token expiry on app launch. We were previously only checking when the menu bar window was opened, and Connect was disabled. We need to account for when Connect is configured to start when the app is launched.