Skip to content

chore: add API errors to SDK #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2024
Merged

chore: add API errors to SDK #12

merged 2 commits into from
Dec 16, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Dec 13, 2024 •
edited
Loading

Cleanup PR to:

  • Handle error responses from SDK, improve the error handling
  • Replace the login flow errors with a popup, so we can actually display the full error
  • Update ViewInspector and fix a deprecation warning in the tests
image

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review December 13, 2024 02:38
spikecurtis
spikecurtis approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline, but I don't need to review again.

@ethanndickson ethanndickson merged commit b338777 into main Dec 16, 2024
1 check passed
@ethanndickson ethanndickson deleted the ethan/api-errs branch January 23, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @spikecurtis