Skip to content

Opening the app with an expired token should sign the user out #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethanndickson opened this issue Mar 11, 2025 · 0 comments · Fixed by #109
Closed

Opening the app with an expired token should sign the user out #107

ethanndickson opened this issue Mar 11, 2025 · 0 comments · Fixed by #109
Assignees

Comments

@ethanndickson
Copy link
Member

If the user's supplied session token expires whilst logged in, they won't find out until they next attempt to turn the VPN on, at which point they need to then log out, and log back in.
We should instead check if the token is expired when the app starts, and sign the user out if it is.

@ethanndickson ethanndickson self-assigned this Mar 11, 2025
ethanndickson added a commit that referenced this issue Mar 18, 2025
Closes #107.

When the menu bar icon is clicked, and the user is signed in, and the VPN is disabled, the app will check if the token is expired. If it is, the user will be signed out.

We could have checked this when the VPN is enabled, but the UX seemed worse, and the implementation would have been messy. We would have needed to sign the user out and show an error. Instead, we'll check for expiry in a scenario where the next user step would likely be an interaction that requires a session. 
This approach also future-proofs for when functionality becomes usable without the VPN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant