Update password stored as a SHA256 hash in cookie #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR doesn't really add any security. Sure you can't tell what the original password is but you can still log into code-server with the hash which just acts as the password. Instead, we should hash the password server side and not store it in memory as plaintext and then hash the client side when comparing. |
|
No activity since PR was opened. Closing to keep the PR queue clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
The authentication password is stored in plain-text in a cookie named password.
Some may not see this as a security issue for automatically generated passwords (although bad practice) but it is definitively an issue when setting a custom password.
Therefore switching from a plain-text stored password to a SHA256 hash is a quick first step in the right direction (aka. I agree it could be better, eg. salted hash).
I saw that there are pull requests providing other solutions (eg. #931 ) for authentication methods which were blocked by GH-857, but really think this pull request should be merged in for the next v1 release.
Is there an open issue you can link to?
Issue #515 (Issue #565)