Add docker-in-docker instructions for k8s #941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-parlette
requested review from
code-asher and
kylecarbs
as code owners
sr229
suggested changes
Sep 12, 2019
| app: code-server | ||
| spec: | ||
| initContainers: | ||
| - name: copy-docker-binary |
There was a problem hiding this comment.
Can't you do this in a Dockerfile instead? It should lessen the need to allocate additional resources for such a task that a image build would be more fit to.
There was a problem hiding this comment.
The problem with using a Dockerfile is that we have to push and maintain the image @sr229.
I suppose its not a big deal though to include the docker CLI by default in codercom/code-server.
|
The problem here is volume mounts won't work properly. code-server and the daemon need to share the root file system. The move here is probably to add a new code-server image that includes the docker daemon and then add a K8s example for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
I wanted to do docker development within a
code-servercontainer, but the docker binary and daemon weren't available. This PR is my kubernetes deployment that solves this problem using the official docker image.I wasn't sure exactly where it should go, or if I should include all of the other parts for a kubernetes setup (like the service, ingress, persistent volume claim, or config map), let me know if you'd like the complete example.
Is there an open issue you can link to?
I originally posted this kubernetes example in #199, but a doc PR makes more sense for anyone looking to self-host
code-server.