Skip to content

#914 - New helm chart for v1 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Conversation

paolomainardi
Copy link
Contributor

@paolomainardi paolomainardi commented Aug 18, 2019

Refs to #914

This PR adds an helm chart as another deployment option for Kubernetes.

I've made 1 opinionated decision for the persistence storage, by keeping persistent /home/coder/project and /home/coder/.local/share/code-server directory which basically contains all the vscode configurations, such as extensions, settings etc.

The helm chart includes an extensive README that should cover all the aspects to install and configure code-server.

The helm chart is now compatible with the latest stable version, but once the v2 will be out, the helm chart can be updated accordingly (it's just a matter of changing the port for now).

It still misses:

  • Define runtime variables from helm chart
  • Generate a k8s secret for PASSWORD
  • Make the args configurable

@paolomainardi paolomainardi changed the title refs #914: New helm chart for v1 #914 New helm chart for v1 Aug 18, 2019
@paolomainardi paolomainardi changed the title #914 New helm chart for v1 #914 - New helm chart for v1 Aug 18, 2019
@paolomainardi paolomainardi changed the title #914 - New helm chart for v1 WIP - #914 - New helm chart for v1 Aug 18, 2019
@paolomainardi paolomainardi changed the title WIP - #914 - New helm chart for v1 #914 - New helm chart for v1 Aug 18, 2019
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty comprehensive. Persisting the ~/.local/share/code-server directory seems fine to me.

Copy link
Contributor

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can LGTM this since my suggestions were applied and OP seems to defend their config decisions adequately.

@deansheather
Copy link
Member

Blocked on PGP signatures. I can merge this once you've signed all of your commits! 🔑

@paolomainardi
Copy link
Contributor Author

@deansheather signed and squashed 👍

@deansheather deansheather merged commit 0f1bbc3 into coder:master Aug 20, 2019
@deansheather
Copy link
Member

Thanks for contributing this!

@paolomainardi
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants