-
Notifications
You must be signed in to change notification settings - Fork 5.9k
#914 - New helm chart for v1 #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty comprehensive. Persisting the ~/.local/share/code-server
directory seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can LGTM this since my suggestions were applied and OP seems to defend their config decisions adequately.
Blocked on PGP signatures. I can merge this once you've signed all of your commits! 🔑 |
@deansheather signed and squashed 👍 |
Thanks for contributing this! |
Thanks for merging! |
Refs to #914
This PR adds an helm chart as another deployment option for Kubernetes.
I've made 1 opinionated decision for the persistence storage, by keeping persistent
/home/coder/project
and/home/coder/.local/share/code-server
directory which basically contains all the vscode configurations, such as extensions, settings etc.The helm chart includes an extensive README that should cover all the aspects to install and configure code-server.
The helm chart is now compatible with the latest stable version, but once the v2 will be out, the helm chart can be updated accordingly (it's just a matter of changing the port for now).
It still misses: