Modify webpack-pwa-manifest config to support iOS icon #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @admvx. However, WebpackPwaManifest isn't used in v2 so this PR is not necessary anymore. @code-asher should it be added back somewhere or is there a new mechanism? |
|
No sweat, thanks for following up! This would still be useful to me, so I have an update that doesn't use WebpackPwaManifest - PR on the way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
The auto-generated icon for Code Server on iPad and other iOS devices was partially broken and unreadable. This change makes use of the existing support in webpack-pwa-manifest to assign the real app icon to the appropriate meta tag in the app HTML file.
Is there an open issue you can link to?
#802