Fix service worker path #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr229
approved these changes
Jul 7, 2019
|
Just read everything and it seems fine. I do recommend adding Co-Authored-By so the OP of the PR can still get credited. |
Co-Authored-By: Ian Reinhart Geiser <[email protected]>
Co-Authored-By: Ian Reinhart Geiser <[email protected]>
kylecarbs
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
This addresses #670 by making the service worker register at the base of the mount. I also changed it so that workbox is hosted from local and not a CDN. This helps simplify CSP issues that pop up when mounting as part of a larger site. There are still quite a few other ones once we start talking plugins but this is a start.
Is there an open issue you can link to?
Closes #670.
Note: this was originally opened in #722 by @geiseri but blocked by inactive user and no PGP signature.