Replace express-static-gzip with a gunzipping version #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
express-static-gzip doesn't gunzip gzipped files for clients that don't have 'Accept-Encoding: gzip', so it has been replaced by a simple clone that does the same thing as the original module and also uses zlib to gunzip the .gz file. This middleware is compatible with files that aren't .gz in the rootFolder, although it will not gzip them on the fly (to my knowledge).
deansheather
changed the title
Closed
|
CL rendered Obsolete. We don't use this layout anymore so I'm closing this off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
express-static-gzipdoesn't gunzip gzipped files for clients that don't haveAccept-Encoding: gzip, so it has been replaced by a simple clone that does the same thing as the original module and also useszlib(native module) to gunzip the.gzfile when the client does not support gzip encoding.This middleware is compatible with files that aren't
.gzin therootFolder, although it will not gzip them on the fly (to my knowledge). It should also be compatible with accessing the raw gzipped files by adding.gzto the URL.Is there an open issue you can link to?
GH-651, possibly GH-773