Add support for multiple listen addresses: --bind #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- '--bind' can be supplied multiple times to add multiple listening addresses. - '--host' and '--port' are now deprecated (they will be automatically translated to a '--bind').
|
Do we still need this PR? I don't think we need this anymore due to much more unrelated v2 tree. |
|
Blocked due to outdated tree. Please rebase. |
deansheather
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
This PR allows for listening on multiple address/port combinations at the same time, which in turn fixes a problem where listening on port 80 (without
--allow-http) would cause the HTTP=>HTTPS redirect to fail.--bindcan be supplied multiple times and is accepted in the form[HOST][:PORT]. If the host or the port is not supplied, they will be filled with the default values0.0.0.0andprocess.env.PORT || 8443. If the user is using the now deprecated--hostand--portarguments, they will be translated to a--bindargument automatically.Additionally, you now cannot use
--host/--portand--bindat the same time, and you cannot use--bindand--socketat the same time now. This will result in an error and code-server exiting.A warning is printed when the user listens on
address:80but notaddress:443when--allow-httpis false.Is there an open issue you can link to?
#737