Set NODE_ENV and VERSION when building #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix the version flag not reporting correctly as well as enable the service worker and prevent the 404 hmr requests again.
To help make sure it's built correctly when looking at the Travis logs.
andreimc
added a commit
to devonlineco/code-server
that referenced
this pull request
May 22, 2019
* upstream/master: Show hidden files by default Fix human readable byte size when zero Expose actions registry (coder#701) Set NODE_ENV and VERSION when building (coder#700) Don't try to create builtin extensions directory Suppress "disconnected" notification on extension host Extra extensions directories (coder#694) Updated Data Directory Flag (coder#664) Remove broken links (coder#671)
code-asher
added a commit
that referenced
this pull request
Jun 19, 2019
* Set NODE_ENV and VERSION when building Should fix the version flag not reporting correctly as well as enable the service worker and prevent the 404 hmr requests again. * Log env vars To help make sure it's built correctly when looking at the Travis logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the version flag not reporting correctly as well as enable
the service worker and prevent the 404 hmr requests again.
Fixes #699.