Skip to content

Update Code to 1.87.0 #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

Update Code to 1.87.0 #6697

merged 1 commit into from
Feb 29, 2024

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Feb 29, 2024

Fixes #6694

@benz0li benz0li requested a review from a team as a code owner February 29, 2024 08:34
@benz0li
Copy link
Contributor Author

benz0li commented Feb 29, 2024

code-server-4.22.0-rc.1-linux-amd64.tar.gz with Code 1.87.0 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

@benz0li
Copy link
Contributor Author

benz0li commented Feb 29, 2024

Ping @code-asher.

Please review and let the checks run.

@benz0li
Copy link
Contributor Author

benz0li commented Feb 29, 2024

Some warnings during yarn build:vscode: yarn-build-vscode_warnings.txt

code-asher
code-asher approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

The warnings look harmless enough but maybe they are caused by a mismatch in Node versions since they updated the version of Node? I will get us updated after merging this and see if it fixes the warnings.

Edit: nevermind, the version is not updated until 1.88. But I will still take a look at the warnings. Maybe we have the wrong version of @types/node installed.

@benz0li
Copy link
Contributor Author

benz0li commented Feb 29, 2024

maybe they are caused by a mismatch in Node versions

That may be the cause. I currently use node v18.19.1 – the latest version of Node v18.

@code-asher code-asher merged commit e5d145f into coder:main Feb 29, 2024
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
@benz0li @yiliang114
Update Code to 1.87.0 (coder#6697)
81cefa9 
Fixes coder#6694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Update Code to 1.87
2 participants
@benz0li @code-asher