Skip to content

Update Code to 1.82.3 #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Update Code to 1.82.3 #6472

merged 1 commit into from
Oct 4, 2023

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Oct 4, 2023

Ping @code-asher: Security release

@benz0li benz0li requested a review from a team as a code owner October 4, 2023 06:48
@benz0li
Copy link
Contributor Author

benz0li commented Oct 4, 2023

code-server-4.17.2-rc.1-linux-amd64.tar.gz is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

@benz0li
Copy link
Contributor Author

benz0li commented Oct 4, 2023

IMHO no RC required. Just put out a proper release.

@code-asher
Copy link
Member

code-asher commented Oct 4, 2023

1.82.3 looks like it only has a bump to Electron which code-server does not use so I think we will not benefit from making a release honestly. Still makes sense to merge it in though, I think.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher enabled auto-merge (squash) October 4, 2023 16:42
@benz0li
Copy link
Contributor Author

benz0li commented Oct 4, 2023

I think we will not benefit from making a release honestly.

Agreed.

@code-asher code-asher merged commit c095c26 into coder:main Oct 4, 2023
@Rucadi
Copy link

Rucadi commented Oct 19, 2023

1.82.3 looks like it only has a bump to Electron which code-server does not use so I think we will not benefit from making a release honestly. Still makes sense to merge it in though, I think.

I would usually agree to this, but some extensions check against the release version, so some of them will not install due to version mismatch, (the latests versions or copilot are almost always forcing you to have the latest version number)

@code-asher
Copy link
Member

Ohh yeah that is a really good point. We are going to release soon with 1.83.1 but I will keep that in mind for the future.

yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants