Skip to content

expose terminal service in IDE API #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2019
Merged

expose terminal service in IDE API #633

merged 1 commit into from
May 2, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented May 2, 2019

No description provided.

@nhooyr
Copy link
Contributor Author

nhooyr commented May 2, 2019

@code-asher what do you think of just returning the service collection from the IDE api instead?

@nhooyr nhooyr force-pushed the show-terminal-api branch 2 times, most recently from 279b3ed to 3052b6a Compare May 2, 2019 14:23
@nhooyr nhooyr changed the title Add createTerminal to IDE API expose terminal service in IDE API May 2, 2019
@nhooyr nhooyr force-pushed the show-terminal-api branch from 3052b6a to 6ef1628 Compare May 2, 2019 14:27
@nhooyr nhooyr merged commit f36235e into master May 2, 2019
@nhooyr nhooyr deleted the show-terminal-api branch May 2, 2019 15:08
code-asher pushed a commit that referenced this pull request Jun 19, 2019
expose terminal service in IDE API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant