Update Code to 1.79.2 #6264
Update Code to 1.79.2 #6264
Conversation
code-asher
force-pushed
the
code-1.79
branch
2 times, most recently
from
bce253d to
6623c49
Compare
Mostly just the usual shifting or changing of the surrounding context but I did refactor the getting started block we insert because it keeps getting mangled on each update. Instead of shifting things around the columns I just prepend it to the right column.
|
Getting 404s on some vsda module but everything seems to work without it and I do not see it referenced in the package.json nor anywhere on npmjs.com so it seems to be optional. |
|
Trying on NixOS now. |
|
Do you plan to tag a new release? |
|
GitHub release will take a bit longer (not a blocker for NixOS of course), then assuming nothing goes wrong we will promote the RC tomorrow or so. |
|
By the way you may have already come up with a good way to run that postinstall script but if not I wonder if we can edit the |
|
So basically, the idea is to alter this line only? |
|
Yup, exactly. |
|
I'll do it within the update then. |
|
We still need to do something about the commit variable, too. Looks like it used to be a hardcoded variable so maybe we do that again: https://github.com/NixOS/nixpkgs/blob/5e1324e48a7a05e150f7d05489dfb7507a29d87e/pkgs/servers/code-server/default.nix#L17 Or maybe there is some better way to automatically get the commit. |
|
Hmm actually the |
|
I'm not the person who did that NixOS module and I have absolutely no clue into it, I'm just willing to update it. Do you mind submitting a PR against |
|
Yup that works for me! |
|
Ping me when it's done so I can take care of the PR myself :) |
|
Bad news, I can't compile 4.14rc1 neither
|
|
😱 I will check into it! |
|
@code-asher I will deploy v4.14.0-rc.1 within the next hour and do the usual smoke tests. |
|
@code-asher Is there only the source code for v4.14.0-rc.1? No other assets? |
|
P.S.: 1.79.2 released. |
|
@benz0li Oh no hmm...something must have gone wrong with the build job. |
|
I might as well throw in 1.79.2 first. |
|
Weird, I used their Looking into the missing assets now. |
|
Turns out the job is fine, I just somehow completely forgot that we have to manually run the "draft release" workflow. Really need to automate that at some point. 🤦 Assets are attached now. |
|
Functionality [modified by patches] tested and found to work:
Jupyter Notebooks also work fine: |
Mostly just the usual shifting or changing of the surrounding context but I did refactor the getting started block we insert because it keeps getting mangled on each update. Instead of shifting things around the columns I just prepend it to the right column. Getting 404s on some vsda module but everything seems to work without it and I do not see it referenced in the package.json nor a nywhere on npmjs.com so it seems to be optional.
Mostly just the usual shifting or changing of the surrounding context but I did refactor the getting started block we insert because it keeps getting mangled on each update. Instead of shifting things around the columns I just prepend it to the right column.
Closes #6257