Skip to content

Update to 1.78.2 #6201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2023
Merged

Update to 1.78.2 #6201

merged 3 commits into from
May 15, 2023

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented May 9, 2023 •
edited
Loading

No changes needed in the patches other than moving some lines around and updating the CSP hash as usual.

The flake had to be updated as it was using Node 16.16 and 16.17 is required at minimum now. Also python seems to install Python 2 which is marked as deprecated so explicitly install python3.

Also had to update the environment variable used to provide the commit during build.

Closes #6190

@code-asher
Update to 1.78.1
5a899d6 
No changes needed in the patches other than moving some lines around and
updating the CSP hash as usual.

The flake had to be updated as it was using Node 16.16 and 16.17 is
required at minimum now.  Also python seems to install python2 which is
marked as deprecated so explicitly install python3.
@code-asher code-asher requested a review from a team as a code owner May 9, 2023 22:45
@benz0li
Copy link
Contributor

benz0li commented May 12, 2023

@code-asher Straight to v1.78.2?

Cross references:

@code-asher
Update to 1.78.2
3e2743d 
Patches applied without any conflicts.
@code-asher code-asher changed the title Update to 1.78.1 Update to 1.78.2 May 12, 2023
@code-asher
Copy link
Member Author

Changing the display language appears to be broken. Looking into it...

@benz0li
Copy link
Contributor

benz0li commented May 13, 2023

I look forward to this release.

Finally I can update code-server 4.9.1 (Code 1.73.1; Nov 9, 2022) to a current version in my JupyterLab docker stacks.

@code-asher
Update commit environment variable
4b404c2 
This was causing the commit not to be set.  It broke display languages
since that has a hard dependency on the commit for directory names.
Possibly broke other things.
@code-asher code-asher merged commit 43ef50b into coder:main May 15, 2023
@code-asher code-asher deleted the vscode-1.78.1 branch May 15, 2023 23:44
@benz0li
Copy link
Contributor

benz0li commented May 16, 2023 •
edited
Loading

code-server-4.13.0-rc.1-linux-amd64.tar.gz from Release v4.13.0-rc.1 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

Terminal is rendered properly again in Safari with the default setting "terminal.integrated.gpuAcceleration": "auto".

FYI @code-asher

@code-asher
Copy link
Member Author

Great news! Thank you for testing. 🎉 I will put out a promoted release by the end of the day.

@code-asher
Copy link
Member Author

I ran out of time yesterday but I am thinking I throw in the vm2 vulnerability update (it is running afoul of some security checkers for us) and a small patch to unblock some users having issues with the origin check, do one more RC, then finally full release.

@benz0li
Copy link
Contributor

benz0li commented May 17, 2023

I ran out of time yesterday

No worries.

but I am thinking I throw in the vm2 vulnerability update (it is running afoul of some security checkers for us) and a small patch to unblock some users having issues with the origin check, do one more RC, then finally full release.

Go ahead. Security first.

@benz0li
Copy link
Contributor

benz0li commented May 18, 2023

code-server-4.13.0-rc.2-linux-amd64.tar.gz from Release v4.13.0-rc.2 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Same (positive) results as Release v4.13.0-rc.1. 👍

@drupol
Copy link

drupol commented Jun 1, 2023

Just FYI, we are unable to update to version 4.13 in Nix, I opened an issue at #6244

Looks like there's something broken while compiling, almost at the end.

yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
@code-asher @yiliang114
Update to 1.78.2 (coder#6201)
a38b2a0 
* Update to 1.78.1

No changes needed in the patches other than moving some lines around and
updating the CSP hash as usual.

The flake had to be updated as it was using Node 16.16 and 16.17 is
required at minimum now.  Also python seems to install python2 which is
marked as deprecated so explicitly install python3.

* Update to 1.78.2

Patches applied without any conflicts.

* Update commit environment variable

This was causing the commit not to be set.  It broke display languages
since that has a hard dependency on the commit for directory names.
Possibly broke other things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Update Code to 1.78
3 participants
@code-asher @benz0li @drupol