Skip to content

Add debug log for origin check #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

code-asher
Copy link
Member

Extracted host detection into a separate function to avoid multiple log lines on each return.

To help debug #6064

@code-asher code-asher force-pushed the debug-origin branch 4 times, most recently from 2737ecb to a5ef4be Compare March 21, 2023 21:15
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #6096 (5cebc2b) into main (bca733d) will increase coverage by 0.07%.
The diff coverage is 94.11%.

❗ Current head 5cebc2b differs from pull request most recent head 2bac577. Consider uploading reports for the commit 2bac577 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6096      +/-   ##
==========================================
+ Coverage   73.00%   73.08%   +0.07%     
==========================================
  Files          30       30              
  Lines        1708     1713       +5     
  Branches      377      379       +2     
==========================================
+ Hits         1247     1252       +5     
  Misses        385      385              
  Partials       76       76              
Impacted Files Coverage Δ
src/node/http.ts 69.92% <94.11%> (+1.17%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32a31d...2bac577. Read the comment docs.

@code-asher code-asher marked this pull request as ready for review March 22, 2023 19:09
@code-asher code-asher requested a review from a team as a code owner March 22, 2023 19:09
@code-asher code-asher force-pushed the debug-origin branch 3 times, most recently from b7db1d2 to 5cebc2b Compare March 22, 2023 19:45
Extracted host detection into a separate function to avoid multiple log
lines on each return and went with a thrown error to consolidate the
common log text.
@code-asher code-asher merged commit 19bcd04 into coder:main Mar 30, 2023
@code-asher code-asher deleted the debug-origin branch March 30, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant