Add task for packaging release #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
feature/release-script
branch
2 times, most recently
from
2b35d4f to
5478f3a
Compare
kylecarbs
reviewed
Mar 5, 2019
code-asher
force-pushed
the
feature/release-script
branch
2 times, most recently
from
b9894d3 to
69133cb
Compare
|
Optimally we'd fix the |
This is so it can be used as part of the build/release script.
code-asher
force-pushed
the
feature/release-script
branch
from
561e786 to
85c192e
Compare
| runner.cwd = releasePath; | ||
| await os.platform() === "linux" | ||
| ? runner.execute("tar", ["-cvzf", `${archiveName}.tar.gz`, `${archiveName}`]) | ||
| : runner.execute("zip", ["-r", `${archiveName}.zip`, `${archiveName}`]); |
There was a problem hiding this comment.
For our use case, is tar preferable to zip? And if so, is there any way for us to set a conditional based on whether or not said commands are installed rather than OS platform? Or is it inconsequential and/or not worth the time?
There was a problem hiding this comment.
The goal is to provide tarballs for Linux builds and zips for Mac & Windows builds. This runs in the CI and is what will be available for download on the releases page.
code-asher
added a commit
that referenced
this pull request
Jun 19, 2019
* Add task for packaging release * Modify package task to package a single binary This is so it can be used as part of the build/release script. * Package release as part of Travis deploy * Set platform env var * Add arch env var * Make version available to the code * Use tar for Linux and zip for Mac & Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.