Skip to content

feat(helm-chart): Add support for extraSecretMounts subPath (#5960) #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

BlueNc
Copy link
Contributor

@BlueNc BlueNc commented Jan 11, 2023

Fixes #5960

@jsjoeio jsjoeio self-assigned this Jan 13, 2023
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 13, 2023

@Matthew-Beckett mind helping us review this?

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #5961 (368ecec) into main (7c2aa8c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5961   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files          31       31           
  Lines        1696     1696           
  Branches      372      372           
=======================================
  Hits         1217     1217           
  Misses        401      401           
  Partials       78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2aa8c...368ecec. Read the comment docs.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this one, and thank you!

@code-asher code-asher merged commit 6d8ed77 into coder:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add support for extraSecretMounts subPath in helm-chart
3 participants