Skip to content

refactor: rm node_mods caching in release workflow #5895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,22 +67,12 @@ jobs:
- name: Decompress npm package
run: tar -xzf package.tar.gz

- name: Fetch dependencies from cache
id: cache-node-modules
uses: actions/cache@v3
with:
path: "**/node_modules"
key: yarn-build-linux-amd64-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
yarn-build-linux-amd64-
# NOTE: && here is deliberate - GitHub puts each line in its own `.sh`
# file when running inside a docker container.
- name: Build standalone release
run: source scl_source enable devtoolset-9 && npm run release:standalone

- name: Install test dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: SKIP_SUBMODULE_DEPS=1 yarn --frozen-lockfile

- name: Run integration tests on standalone release
Expand Down Expand Up @@ -237,20 +227,10 @@ jobs:
- name: Decompress npm package
run: tar -xzf package.tar.gz

- name: Fetch dependencies from cache
id: cache-node-modules
uses: actions/cache@v3
with:
path: "**/node_modules"
key: yarn-build-macos-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
yarn-build-macos-
- name: Build standalone release
run: npm run release:standalone

- name: Install test dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: SKIP_SUBMODULE_DEPS=1 yarn install

- name: Run native module tests on standalone release
Expand Down