refactor: use separate cache key in release, run standalone after caching #5859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5859 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 30 30
Lines 1688 1688
Branches 371 371
=======================================
Hits 1265 1265
Misses 361 361
Partials 62 62 Continue to review full report at Codecov.
|
jsjoeio
force-pushed
the
jsjoeio/wip-fix
branch
from
828131c to
44339d5
Compare
jsjoeio
changed the title
Kira-Pilot
reviewed
Dec 12, 2022
ci/build/npm-postinstall.sh
Outdated
| @@ -132,7 +132,7 @@ install_with_yarn_or_npm() { | |||
| # HACK: NPM's use of semver doesn't like resolving some peerDependencies that vscode (upstream) brings in the form of pre-releases. | |||
| # The legacy behavior doesn't complain about pre-releases being used, falling back to that for now. | |||
| # See https://github.com//pull/5071 | |||
| npm install --unsafe-perm --legacy-peer-deps --omit=dev | |||
| npm install --unsafe-perm --legacy-peer-deps --omit=dev -ddd | |||
There was a problem hiding this comment.
Silly logging! https://docs.npmjs.com/cli/v8/using-npm/logging#aliases
I may want to remove it though 🤔
Kira-Pilot
approved these changes
Dec 12, 2022
jsjoeio
commented
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a caching issue causing dependency issues in the release. This now uses a separate cache key across OS's and it runs the standalone release after restoring cache. If we don't do this, the cache in the standalone release is overwritten which we don't want.