Skip to content

fix: use npm and yarn consistently in build and release #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 12, 2022
Merged

fix: use npm and yarn consistently in build and release #5852

merged 23 commits into from
Dec 12, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 8, 2022

  • refactor: remove keytar dep in cross-compile
  • refactor: try other keytar package

@jsjoeio jsjoeio requested a review from a team as a code owner December 8, 2022 19:02
@jsjoeio jsjoeio changed the title jsjoeio/fix cross compile fix: try other keytar package Dec 8, 2022
@jsjoeio jsjoeio self-assigned this Dec 8, 2022
@jsjoeio jsjoeio added this to the December 2022 milestone Dec 8, 2022
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 19:05 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5852!

  • Last publish status: success
  • Commit: 7ca79bd

To install in a local project, run:

npm install @coder/code-server-pr@5852

To install globally, run:

npm install -g @coder/code-server-pr@5852

@codecov
Copy link

codecov bot commented Dec 8, 2022 •
edited
Loading

Codecov Report

Merging #5852 (7ca79bd) into main (ef5865f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5852   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          30       30           
  Lines        1688     1688           
  Branches      371      371           
=======================================
  Hits         1265     1265           
  Misses        361      361           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5865f...7ca79bd. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 19:35 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 19:44 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 19:48 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 19:55 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 20:04 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 20:07 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 20:10 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 20:37 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 21:03 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 8, 2022 21:17 — with GitHub Actions Inactive
@jsjoeio jsjoeio changed the title fix: try other keytar package fix: use npm and yarn consistently in build and release Dec 8, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 12, 2022

@code-asher can you review this?

@jsjoeio jsjoeio temporarily deployed to npm December 12, 2022 17:40 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 12, 2022 21:16 — with GitHub Actions Inactive
@repo-ranger repo-ranger bot temporarily deployed to npm December 12, 2022 21:27 Inactive
@repo-ranger repo-ranger bot merged commit 1efc5f1 into main Dec 12, 2022
@repo-ranger repo-ranger bot deleted the jsjoeio/fix-cross-compile branch December 12, 2022 21:41
@jsjoeio jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @Kira-Pilot