-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore: update download artifacts in release #5841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
check_artifacts: false | ||
if_no_artifact_found: fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the defaults but I opted to be explicit for these reasons:
- won't break if defaults change
- maintainers don't have to go to docs to see defaults because we're explicit here
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5841 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 30 30
Lines 1688 1688
Branches 371 371
=======================================
Hits 1265 1265
Misses 361 361
Partials 62 62 Continue to review full report at Codecov.
|
A while back, @code-asher and I discussed improving the "Download artifacts" step in the
release.yaml
workflow.These changes make it more "sturdy" because we now
fail
if no artifact found in the latestcompleted
build.yaml
workflow.Pros
Cons