Skip to content

chore: add VERSION check in build-vscode.sh #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Nov 30, 2022

This adds a check to ensure VERSION is set if running build:vscode locally.

Fixes #5795

@jsjoeio jsjoeio self-assigned this Nov 30, 2022
@jsjoeio jsjoeio added this to the November 2022 milestone Nov 30, 2022
@jsjoeio jsjoeio marked this pull request as ready for review November 30, 2022 19:43
@jsjoeio jsjoeio requested a review from a team as a code owner November 30, 2022 19:43
@jsjoeio jsjoeio temporarily deployed to npm November 30, 2022 19:52 Inactive
@github-actions
Copy link

✨ code-server dev build published to npm for PR #5823!

  • Last publish status: success
  • Commit: 7f9df15

To install in a local project, run:

npm install @coder/code-server-pr@5823

To install globally, run:

npm install -g @coder/code-server-pr@5823

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #5823 (7f9df15) into main (2cbb113) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5823   +/-   ##
=======================================
  Coverage   72.66%   72.66%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      370      370           
=======================================
  Hits         1223     1223           
  Misses        397      397           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbb113...7f9df15. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge (squash) November 30, 2022 20:49
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsjoeio jsjoeio merged commit df49838 into main Dec 1, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-version-build branch December 1, 2022 16:51
@jsjoeio jsjoeio modified the milestones: November 2022, 4.9.0 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The version number in package.json is 0.0.0, which causes an error in yarn build: vscode
2 participants