-
Notifications
You must be signed in to change notification settings - Fork 6.1k
release: 4.9.0 #5772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
release: 4.9.0 #5772
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9694242
wip: changelog
jsjoeio 17d4113
fixup
jsjoeio 96b3c3e
Merge branch 'main' into release/v4.9.0
jsjoeio ccf882f
Merge branch 'main' into release/v4.9.0
jsjoeio 9efbd2d
Merge branch 'main' into release/v4.9.0
jsjoeio fc4d2b5
fix: add +x to product.json in build-vscode
jsjoeio c9279cc
Merge branch 'main' into release/v4.9.0
jsjoeio 130f52e
chore: increase timeout
jsjoeio 0f66360
fix: keep product.json file permissions in release
jsjoeio f7db2a0
trigger ci
jsjoeio ace0910
chore: update package.json bust cache
jsjoeio 2b32b10
fixup!: fix: keep product.json file permissions in release
jsjoeio 956ed96
Revert "fix: add +x to product.json in build-vscode"
jsjoeio c761199
chore: pin ubuntu runner in build code-server
jsjoeio e701b74
chore: update prettierignore
jsjoeio 0c7a60e
chore: add notes to changelog
jsjoeio 40396cc
chore: use ubuntu-22.04 for e2e
jsjoeio 60ab23f
chore: pin all jobs in build to ubuntu 20.04
jsjoeio 292a63d
Merge branch 'main' into release/v4.9.0
jsjoeio 73b61ec
feat(wrapper): add tests for isChild
jsjoeio 8ed7498
fixup: include description ts-expect-error comment
jsjoeio a89d3e3
chore: update CHANGELOG
jsjoeio 4a5ef4c
chore: update Helm chart
jsjoeio 73faddd
fixup: use our childProcess
jsjoeio 99033dd
Update CHANGELOG.md
jsjoeio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
lib/vscode | ||
lib/vscode-reh-web-linux-x64 | ||
release-standalone | ||
release-packages | ||
release | ||
helm-chart | ||
test/scripts | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { ChildProcess } from "child_process" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to release. Added to keep code coverage from decreasing and CI ✅ |
||
import { ParentProcess, isChild } from "../../../src/node/wrapper" | ||
|
||
describe("wrapper", () => { | ||
describe("isChild", () => { | ||
it("should return false for parent process", () => { | ||
const p = new ParentProcess("1") | ||
expect(isChild(p)).toBe(false) | ||
}) | ||
}) | ||
it("should return false for parent process", () => { | ||
const p = new ChildProcess() | ||
// our ChildProcess isn't exported | ||
// and shouldn't be for a test so surpressing TS error. | ||
// @ts-expect-error | ||
expect(isChild(p)).toBe(false) | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.