refactor: get version dynamically

[jsjoeio]

Description

This PR refactors the release process to dynamically get the release version from the workflow inputs. This means we don't have to open a PR into main that modifies the package.json. It also means we'll need to manually modify the CHANGELOG and the Helm chart after doing a release.

Todos

• remove global VERSION
• set anywhere we need it
• standardize input to always include v and then strip when not needed
• update release docs

Screenshot

Testing Plan

• test build flow - published successfully to npm here, successful build CI here (todo link)
• test release flow: run draft release manually, and double-check assets
• test publish flow: copy changes to fork and test publish there. uses the correct input

[github-actions]

✨ code-server dev build published to npm for PR #5753!

• Last publish status: success
• Commit: 2b77611

To install in a local project, run:

npm install @coder/code-server-pr@5753

To install globally, run:

npm install -g @coder/code-server-pr@5753

[codecov]

Codecov Report

Merging #5753 (2b77611) into main (5a8bb2b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5753   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files          30       30           
  Lines        1682     1682           
  Branches      369      369           
=======================================
  Hits         1222     1222           
  Misses        397      397           
  Partials       63       63           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8bb2b...2b77611. Read the comment docs.

[jsjoeio]

First test: draft workflow succeeds. And when you download an asset, it shows the package.json has been updated and the product.json:

However, the assets have the wrong version in their name 🤔

I'm not sure what the root cause of this problem is though.

[jsjoeio]

Okay figured out the issue. we get VERSION from the root package.json. Need to figure out a solution for this.

[code-asher]

Should we also change the package.json version to be development or 0.0.0 or something like that?

[jsjoeio]

Should we also change the package.json version to be development or 0.0.0 or something like that?

Yeah, good call. I'll update it to 0.0.0

[jsjoeio]

Ready for another review 👀

[socket-security]

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

[jsjoeio]

e2e tests failing because it's using a cached version of Code. bumped cache key in secrets.

[code-asher]

We still need to delete this line otherwise the version we set in the workflow gets overridden!

[code-asher]

Do we need this line since we set version in another step?

[jsjoeio]

I think so? Don't we need to set it in every step?

[jsjoeio]

Hmm double-checking..i see what you mean now

[jsjoeio]

Ah, you were right - nice catch. Removed!