-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix: CSP and webview errors #5712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We missed a hash update and also had the wrong hash for another HTML file which caused issues in 4.8.0.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5712 +/- ##
=======================================
Coverage 72.61% 72.61%
=======================================
Files 30 30
Lines 1680 1680
Branches 368 368
=======================================
Hits 1220 1220
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
Decided we need to get this out ASAP so I will add tests later! |
We will publish a release candidate with a fix shortly (probably within the next 3-4 hours) |
@jsjoeio how do I use the install script to install a pre-release version? |
Apologies, that should be documented somewhere. I believe passing |
code-server 4.16.1 94ef377 has the same error |
Hmm I am not seeing an issue on 4.16.1 using Chromium. Are you able to consistently reproduce it? |
I can 100% reproduce this issue. I used the same configuration as this issue (#6421). |
Thank you for the screenshot! Do you trigger this by opening a markdown preview or another way? I have tried a few things (markdown preview, web extension, extension readmes, Jupyter extension) but nothing triggers it for me so far. Do you have any browser extensions installed? I wonder if there is one trying to inject a script. |
Description
When we released 4.8.0, we were using the wrong hash in two HTML files causing various issues related to webviews. This fixes it.
Changes
TODOs
fixes #5711
fixes #5710
fixes #5708