chore(deps): downgrade argon2 to 0.29.0 #5704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why but we were seeing argon2/node-gyp issues after this upgrade while running `yarn release:standalone`. For now, downgrading to 0.29.0 seems to fix the issue when testing locally.
code-asher
approved these changes
Oct 25, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5704 +/- ##
=======================================
Coverage 72.61% 72.61%
=======================================
Files 30 30
Lines 1680 1680
Branches 368 368
=======================================
Hits 1220 1220
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why but we were seeing argon2/node-gyp issues after this
upgrade while running
yarn release:standalone. For now, downgrading to0.29.0 seems to fix the issue when testing locally.