-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore(deps): update prettier and eslint #5700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,6 +1,6 @@ | |||
import { field, Level, logger } from "@coder/logger" | |||
import { promises as fs } from "fs" | |||
import yaml from "js-yaml" | |||
import { load } from "js-yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint caught this
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5700 +/- ##
=======================================
Coverage 72.61% 72.61%
=======================================
Files 30 30
Lines 1680 1680
Branches 368 368
=======================================
Hits 1220 1220
Misses 397 397
Partials 63 63
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Description
Spoke to @code-asher offline who suggested updating our dependencies to avoid the
minimatch
resolution. Ranyarn _audit
locally and all looks good!Changes