Skip to content

release: 4.8.0 #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 24, 2022
Merged

release: 4.8.0 #5698

merged 7 commits into from
Oct 24, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 24, 2022

This PR is to generate a new release of code-server at 4.8.0

Screenshot

image

TODOs

Follow "Publishing a release" steps in ci/README.md

  • update CHANGELOG.md
  • manually run "Draft release" workflow after merging this PR
  • merge PR opened in code-server-aur

@jsjoeio jsjoeio self-assigned this Oct 24, 2022
@jsjoeio jsjoeio requested a review from a team October 24, 2022 20:44
@github-actions
Copy link

github-actions bot commented Oct 24, 2022

✨ code-server docs for PR #5698 is ready! It will be updated on every commit.

@jsjoeio jsjoeio marked this pull request as ready for review October 24, 2022 20:54
@jsjoeio jsjoeio temporarily deployed to npm October 24, 2022 21:09 Inactive
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5698 (1e50417) into main (59ef715) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5698   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          30       30           
  Lines        1680     1680           
  Branches      368      368           
=======================================
  Hits         1220     1220           
  Misses        397      397           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ef715...1e50417. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

✨ code-server dev build published to npm for PR #5698!

  • Last publish status: success
  • Commit: 1e50417

To install in a local project, run:

npm install @coder/code-server-pr@5698

To install globally, run:

npm install -g @coder/code-server-pr@5698

@jsjoeio jsjoeio temporarily deployed to npm October 24, 2022 21:28 Inactive
@jsjoeio jsjoeio temporarily deployed to npm October 24, 2022 21:32 Inactive
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 24, 2022

Possible upstream issue with Helm: Azure/setup-helm#99

@@ -3,7 +3,7 @@ Add support for telemetry endpoint
To test:
1. Create a RequestBin - https://requestbin.io/
2. Run code-server with `CS_TELEMETRY_URL` set:
i.e. `CS_TELEMETRY_URL="https://requestbin.io/1ebub9z1" ./code-server-4.7.1-macos-amd64/bin/code-server`
i.e. `CS_TELEMETRY_URL="https://requestbin.io/1ebub9z1" ./code-server-4.8.0-macos-amd64/bin/code-server`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something we need to do now but maybe we generalize the invocation just to just code-server to prevent having to update it on every release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Comment on lines +29 to +32
- Support for the Ports panel which leverages code-server's built-in proxy. It
also uses `VSCODE_PROXY_URI` where `{{port}}` is replace when forwarding a port.
Example: `VSCODE_PROXY_URI=https://{{port}}.kyle.dev` would forward an
application running on localhost:3000 to https://3000.kyle.dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the example! Wonderful use of the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Don’t let your friends dump git logs into changelogs." - applying what I learned from you!

jsjoeio and others added 2 commits October 24, 2022 15:09
@jsjoeio jsjoeio temporarily deployed to npm October 24, 2022 22:11 Inactive
@jsjoeio jsjoeio temporarily deployed to npm October 24, 2022 22:15 Inactive
@jsjoeio jsjoeio requested a review from code-asher October 24, 2022 22:24
@jsjoeio jsjoeio merged commit 2f583b0 into main Oct 24, 2022
@jsjoeio jsjoeio deleted the release/v4.8.0 branch October 24, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants