Skip to content

fix: Enable the BROWSER environment variable #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix: Enable the BROWSER environment variable #5695

merged 1 commit into from
Oct 24, 2022

Conversation

kylecarbs
Copy link
Member

This was breaking the automatic opening of links in GIT_ASKPASS on a git clone. I've tried to execute this script manually, and it does indeed work!

This was breaking the automatic opening of links in GIT_ASKPASS
on a git clone. I've tried to execute this script manually, and
it does indeed work!
@kylecarbs kylecarbs requested a review from a team as a code owner October 24, 2022 15:59
@kylecarbs kylecarbs temporarily deployed to npm October 24, 2022 16:01 Inactive
@github-actions
Copy link

✨ code-server dev build published to npm for PR #5695!

  • Last publish status: success
  • Commit: 6886265

To install in a local project, run:

npm install @coder/code-server-pr@5695

To install globally, run:

npm install -g @coder/code-server-pr@5695

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5695 (6886265) into main (efce005) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5695   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          30       30           
  Lines        1680     1680           
  Branches      368      368           
=======================================
  Hits         1220     1220           
  Misses        397      397           
  Partials       63       63           
Impacted Files Coverage Δ
src/node/routes/vscode.ts 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efce005...6886265. Read the comment docs.

@kylecarbs kylecarbs merged commit 430b567 into main Oct 24, 2022
@kylecarbs kylecarbs deleted the browservar branch October 24, 2022 16:26
@jsjoeio jsjoeio modified the milestones: October 2022, 4.8.0 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants