Skip to content

add docker image release for Ubuntu based image #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2022
Merged

add docker image release for Ubuntu based image #5688

merged 2 commits into from
Oct 24, 2022

Conversation

huweiATgithub
Copy link
Contributor

Fixes #5621

@huweiATgithub huweiATgithub requested a review from a team as a code owner October 23, 2022 01:49
@huweiATgithub
Copy link
Contributor Author

As Ubuntu:focal can use the same Dockerfile as Debian:11, no new Dockerfile is needed.

  • I introduce a ARG $BASE in the Dockerfile so that we can build the ubuntu-based image outside the Dockerfile.
  • I modify back-config to build and tag images.
  • I have tested the ubuntu-based code-server image. It started without issue.

Command VERSION=4.7.2 docker buildx bake -f ci/release-image/docker-bake.hcl --print generate:

{
  "group": {
    "default": {
      "targets": [
        "code-server-debian-11",
        "code-server-ubuntu-focal"
      ]
    }
  },
  "target": {
    "code-server-debian-11": {
      "context": ".",
      "dockerfile": "ci/release-image/Dockerfile",
      "tags": [
        "docker.io/codercom/code-server:latest",
        "docker.io/codercom/code-server:4.7.2",
        "ghcr.io/coder/code-server:latest",
        "ghcr.io/coder/code-server:4.7.2",
        "docker.io/codercom/code-server:debian",
        "docker.io/codercom/code-server:4.7.2-debian",
        "ghcr.io/coder/code-server:debian",
        "ghcr.io/coder/code-server:4.7.2-debian",
        "docker.io/codercom/code-server:bullseye",
        "docker.io/codercom/code-server:4.7.2-bullseye",
        "ghcr.io/coder/code-server:bullseye",
        "ghcr.io/coder/code-server:4.7.2-bullseye"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ]
    },
    "code-server-ubuntu-focal": {
      "context": ".",
      "dockerfile": "ci/release-image/Dockerfile",
      "args": {
        "BASE": "ubuntu:focal"
      },
      "tags": [
        "docker.io/codercom/code-server:ubuntu",
        "docker.io/codercom/code-server:4.7.2-ubuntu",
        "ghcr.io/coder/code-server:ubuntu",
        "ghcr.io/coder/code-server:4.7.2-ubuntu",
        "docker.io/codercom/code-server:focal",
        "docker.io/codercom/code-server:4.7.2-focal",
        "ghcr.io/coder/code-server:focal",
        "ghcr.io/coder/code-server:4.7.2-focal"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ]
    }
  }
}

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5688 (350b4a4) into main (031e903) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5688   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          30       30           
  Lines        1680     1680           
  Branches      368      368           
=======================================
  Hits         1220     1220           
  Misses        397      397           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031e903...350b4a4. Read the comment docs.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant! Well done and thank you. 🎉

@code-asher code-asher enabled auto-merge (squash) October 24, 2022 18:34
@code-asher code-asher merged commit bbf18cc into coder:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: code-server (run with docker) will always overwrite PATH variable
3 participants