Fix coping and moving files around using the file tree #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes cutting and copy files from the file tree work.
This is used by the file tree to copy files.
This makes things like piping streams possible.
This eliminates any chance whatsoever of missing events due to binding too late.
code-asher
force-pushed
the
fix/cut-copy-files
branch
from
cdeee83 to
970afb5
Compare
kylecarbs
approved these changes
Apr 23, 2019
code-asher
force-pushed
the
fix/cut-copy-files
branch
from
f9c8491 to
6afcd5c
Compare
kylecarbs
approved these changes
Apr 24, 2019
code-asher
force-pushed
the
fix/cut-copy-files
branch
from
6afcd5c to
1658f1b
Compare
This was referenced Apr 25, 2019
code-asher
added a commit
that referenced
this pull request
Jun 19, 2019
* Implement write/read buffers in electron fill This makes cutting and copy files from the file tree work. * Implement fs.createReadStream This is used by the file tree to copy files. * Allow passing proxies back from client to server This makes things like piping streams possible. * Synchronously bind to proxy events This eliminates any chance whatsoever of missing events due to binding too late. * Make it possible to bind some events on demand * Add some protocol documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.createReadStream. This is what is used to copy files from one part of the file tree to another (viapipe).dataevent on a stream will make the data start flowing, which is not always desirable. For example if you try topipelater the data may already be partially or completely gone. Now we can delay binding for an event likedatauntil we're asked.pipepossible.proxyId.fs.createReadStreamandpipe.